On Fri, 2011-12-23 at 13:56 +0100, Alexander Graf wrote: > > Hmm, unless smp_send_reschedule must be called with preemption disabled > > (doesn't seem like an obvious requirement, even if callers commonly have > > a reason to do so, and the only documentation of it I see is on the ia64 > > implementation), that seems like a bug in the MPIC IPI implementation. > > > > It wouldn't be an issue (and would make the MPIC driver slightly faster, > > too) if the MPIC driver were to use the magic CPU region instead of > > manually indexing the non-magic array of per-CPU regions. Maybe it > > doesn't work on all hardware the driver supports? Right, the magic per-cpu region doesn't work on all HW. > I'd say that's a question I'll redirect to Ben :). > > > Not that it matters much here -- we want this patch anyway, because we > > want to check that it's not the current CPU. > > Yeah. Well - eventually we want the exact same vcpu_kick function across architectures. > But this is a good step in the right direction. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
