On 12/22/2011 02:39 PM, Christian Borntraeger wrote: > On 22/12/11 13:34, Avi Kivity wrote: > >> The general purpose registers are often necessary to handle SIE exits. > >> Avoid additional ioctls by providing the guest registers in the r/w > >> section of the kvm_run structure. > >> > > > > This is only needed for S390_UCONTROL? > > No for the standard path. It was more like a "we copy the regs around > anyway inside the kernel, so why not use kvm_run as a place to store > the guest regs". So I will probably also have a look at floating point > regs and access registers. Sure, for side effect free registers that's a good approach. I'd copy it for x86, except vmx keeps %rsp cached in the cpu and won't let it out except via an expensive instruction, and also because it's very rarely used (mostly by "info registers" in qemu and live migration). -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html