[PATCH 4/6] kvm tools: Improve 'lkvm {pause,resume}'s output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



lkvm {pause,resume} do not give any feedback to user who uses these
commands in the console where the command run.

This patch makes the command output in the command console instead of
guest console.

Signed-off-by: Asias He <asias.hejun@xxxxxxxxx>
---
 tools/kvm/builtin-pause.c  |   10 +++++++++-
 tools/kvm/builtin-resume.c |   10 +++++++++-
 tools/kvm/builtin-run.c    |    1 -
 3 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/tools/kvm/builtin-pause.c b/tools/kvm/builtin-pause.c
index ee5a5b8..436963f 100644
--- a/tools/kvm/builtin-pause.c
+++ b/tools/kvm/builtin-pause.c
@@ -41,7 +41,15 @@ void kvm_pause_help(void)
 
 static int do_pause(const char *name, int sock)
 {
-	return kvm_ipc__send(sock, KVM_IPC_PAUSE);
+	int r;
+
+	r = kvm_ipc__send(sock, KVM_IPC_PAUSE);
+	if (r)
+		return r;
+
+	printf("Guest %s paused\n", name);
+
+	return 0;
 }
 
 int kvm_cmd_pause(int argc, const char **argv, const char *prefix)
diff --git a/tools/kvm/builtin-resume.c b/tools/kvm/builtin-resume.c
index 9c47183..033a05b 100644
--- a/tools/kvm/builtin-resume.c
+++ b/tools/kvm/builtin-resume.c
@@ -41,7 +41,15 @@ void kvm_resume_help(void)
 
 static int do_resume(const char *name, int sock)
 {
-	return kvm_ipc__send(sock, KVM_IPC_RESUME);
+	int r;
+
+	r = kvm_ipc__send(sock, KVM_IPC_RESUME);
+	if (r)
+		return r;
+
+	printf("Guest %s resumed\n", name);
+
+	return 0;
 }
 
 int kvm_cmd_resume(int argc, const char **argv, const char *prefix)
diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c
index 80806a1..bf39cfb 100644
--- a/tools/kvm/builtin-run.c
+++ b/tools/kvm/builtin-run.c
@@ -522,7 +522,6 @@ static void handle_pause(int fd, u32 type, u32 len, u8 *msg)
 	}
 
 	is_paused = !is_paused;
-	pr_info("Guest %s\n", is_paused ? "paused" : "resumed");
 }
 
 static void handle_vmstate(int fd, u32 type, u32 len, u8 *msg)
-- 
1.7.7.3

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux