Re: [PATCH 2/2] kvm tools: Improve './lkvm {pause,resume}'s output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/21/2011 04:07 PM, Asias He wrote:

> ./lkvm {pause,resume} do not give any feedback to user who uses these
> commands in the console where the command run.
> 
> This patch makes the command output in the command console instead of
> guest console.


I's like notice users in both sides, so don't remove the pr_info?


Thanks
-Wanlong Gao 

> 
> Signed-off-by: Asias He <asias.hejun@xxxxxxxxx>
> ---
>  tools/kvm/builtin-pause.c  |    2 ++
>  tools/kvm/builtin-resume.c |    2 ++
>  tools/kvm/builtin-run.c    |    1 -
>  3 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/kvm/builtin-pause.c b/tools/kvm/builtin-pause.c
> index 107641c..a8e805e 100644
> --- a/tools/kvm/builtin-pause.c
> +++ b/tools/kvm/builtin-pause.c
> @@ -54,6 +54,8 @@ static int do_pause(const char *name, int sock)
>  	if (r < 0)
>  		return r;
>  
> +	printf("Guest %s paused\n", name);
> +
>  	return 0;
>  }
>  
> diff --git a/tools/kvm/builtin-resume.c b/tools/kvm/builtin-resume.c
> index 7b87f59..fd00763 100644
> --- a/tools/kvm/builtin-resume.c
> +++ b/tools/kvm/builtin-resume.c
> @@ -54,6 +54,8 @@ static int do_resume(const char *name, int sock)
>  	if (r < 0)
>  		return r;
>  
> +	printf("Guest %s resumed\n", name);
> +
>  	return 0;
>  }
>  
> diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c
> index fac274c..8f512c3 100644
> --- a/tools/kvm/builtin-run.c
> +++ b/tools/kvm/builtin-run.c
> @@ -515,7 +515,6 @@ static void handle_pause(int fd, u32 type, u32 len, u8 *msg)
>  		return;
>  
>  	is_paused = !is_paused;
> -	pr_info("Guest %s\n", is_paused ? "paused" : "resumed");
>  }
>  
>  static void handle_debug(int fd, u32 type, u32 len, u8 *msg)


--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux