Re: [PATCH 2/2]: kvm-s390: add KVM_S390_GET/SET_SREGS2 call for additional hw regs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[resending because I mistakenly sent an html mime mail before, which got rejected by kvm@vger]

On 20.12.2011, at 12:41, Christian Borntraeger wrote:

> From: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> 
> For guest relocation and virsh dump qemu needs an interface to
> get/set additional registers from kvm. We also need the prefix
> register for all guest memory accesses to the prefix pages.
> 
> The prefix register could also be set via the KVM_S390_SIGP_SET_PREFIX
> interrupt ioctl, but I also added the synchronous operation to have
> 
> o symmetry: we want to have the same struct for get/set routine
> o the interrupt is only delivered before entering the SIE, we also
>  want to cover the sequence set prefix/store status at prefix
> 
> Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> ---
> Documentation/virtual/kvm/api.txt |   31 +++++++++++++++++++++++++++++++
> arch/s390/include/asm/kvm.h       |    9 +++++++++
> arch/s390/kvm/kvm-s390.c          |   30 ++++++++++++++++++++++++++++++
> include/linux/kvm.h               |    4 ++++
> 4 files changed, 74 insertions(+)
> 
> Index: b/Documentation/virtual/kvm/api.txt
> ===================================================================
> --- a/Documentation/virtual/kvm/api.txt
> +++ b/Documentation/virtual/kvm/api.txt
> @@ -1450,6 +1450,37 @@ is supported; 2 if the processor require
> an RMA, or 1 if the processor can use an RMA but doesn't require it,
> because it supports the Virtual RMA (VRMA) facility.
> 
> +4.64 KVM_S390_GET_SREGS2
> +
> +Capability: KVM_CAP_S390_SREGS2
> +Architectures: s390x
> +Type: vcpu ioctl
> +Parameters: struct kvm_sregs2 (out)
> +Returns: 0 on success, -1 on error
> +
> +Reads special registers from the vcpu which are not covered by sregs.
> +
> +/* s390x */
> +struct kvm_sregs2 {
> +	__u64 ckc;	/* clock comparator */
> +	__u64 cputm;	/* cpu timer */
> +	__u64 gbea;	/* guest breaking event address */
> +	__u32 todpr;	/* tod programmable field */
> +	__u32 prefix;	/* prefix register */
> +};

Would it make sense to instead use the GET_ONE_REG and SET_ONE_REG interfaces?

  http://permalink.gmane.org/gmane.comp.emulators.kvm.devel/80854

> +
> +4.65 KVM_S390_SET_SREGS2

I would very much appreciate if you could use 4.66 here. That makes merging the sections for GET_ONE_REG and SET_ONE_REG easier :).


Alex

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux