On 2011-12-14 18:03, Vivek Goyal wrote: >>> I think the allocation in blkio_alloc_blkg_stats() should be moved out >>> of the I/O path into some init function. Copying Jens. >> >> That's completely buggy, basically you end up with a GFP_KERNEL >> allocation from the IO submit path. Vivek, per_cpu data needs to be set >> up at init time. You can't allocate it dynamically off the IO path. > > Hi Jens, > > I am wondering how does CFQ get away with blocking cfqq allocation in > IO submit path. I see that blk_queue_bio() will do following. > > blk_queue_bio() > get_request_wait() > get_request(..,..,GFP_NOIO) > blk_alloc_request() > elv_set_request() > cfq_set_request() > ---> Can sleep and do memory allocation in IO submit path as > GFP_NOIO has __GFP_WAIT. > > So that means sleeping allocation from IO submit path is not necessarily > a problem? __GFP_WAIT isn't the problem, you can block in the IO path. You cannot, however, recurse back into IO submission. That's why CFQ is using GFP_NOIO, implying that waiting is OK, but submitting new IO to satisfy the allocation is not. > But in case of per cpu data allocation, we might be holding > pcpu_alloc_mutex() already at the time of calling pcpu allocation > again and that might lead to deadlock. (As Avi mentioned). If yes, > then it is a problem. It is both a problem and somewhat of a mess... > Right now allocation of root group and associated stats happens at > queue initialization time. For non-root cgroups, group allocation and > associated per cpu stats allocation happens dynamically when the IO is > submitted. So in this case may be we are creating a new blkio cgroup > and then doing IO which leads to this warning. > > I am not sure how to move this allocation to init path. These stats > are per group and groups are created dynamically as IO happens in > them. Only init path seems to be cgroup creation time. blkg is an > object which is contained in a parent object and at that time parent > object is not available. It is created dynamically at the IO time > (cfq_group, blkio_group etc). > > Though it is little hackish but can we just delay the allocation of > stats if pcpu_alloc_mutex is held. We shall have to make > pcpu_alloc_mutex non static though. Delaying will just not capture the > stats for some time and sooner or later we will get regular IO with > pcpu_alloc_mutex not held and we can do per cpu allocation at that > time. I will write a a test patch. > > Or may be there is a safer version of pcpu alloc which will return > without allocation if pcpu_alloc_mutex is already locked. Both of these proposed solutions aren't really pretty. It would be cleaner and have better runtime for the fast path if you could alloc all of these when the non-root groups are setup. Why isn't it done that way right now? -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
