On 14 Dec 2011, at 04:43, Pekka Enberg <penberg@xxxxxxxxxx> wrote: > On Tue, Dec 13, 2011 at 9:00 AM, Matt Evans <matt@xxxxxxxxxx> wrote: >> +int irq__register_device(u32 dev, u8 *num, u8 *pin, u8 *line) >> +{ >> + fprintf(stderr, "irq__register_device(%d, [%d], [%d], [%d]\n", >> + dev, *num, *pin, *line); >> + return 0; >> +} >> + >> +void irq__init(struct kvm *kvm) >> +{ >> + fprintf(stderr, __func__); >> +} >> + >> +int irq__add_msix_route(struct kvm *kvm, struct msi_msg *msg) >> +{ >> + die(__FUNCTION__); >> + return 0; >> +} >> >> +void kvm__irq_line(struct kvm *kvm, int irq, int level) >> +{ >> + fprintf(stderr, "irq_line(%d, %d)\n", irq, level); >> +} > > What's the plan with these functions? Will you need these on PPC? If > yes, why not implement them properly now? If not, we need to drop them > from PPC arch. Yes, they're filled in in the later XICS patch. Cheers, Matt -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html