Am 12.12.2011 11:58, schrieb Pekka Enberg: > On Mon, 12 Dec 2011, Kevin Wolf wrote: >>> @@ -667,14 +722,11 @@ static struct qcow_refcount_block *qcow_read_refcount_block(struct qcow *q, u64 >>> >>> rft_idx = clust_idx >> (header->cluster_bits - QCOW_REFCOUNT_BLOCK_SHIFT); >>> if (rft_idx >= rft->rf_size) >>> - return NULL; >>> + return (void *)-ENOSPC; >> >> Is this allowed style in kvm-tool? :-/ > > It needs to use ERR_PTR() and related macros but otherwise I don't see a > big problem with it. Can you be sure that it never clashes with a valid allocation when you use this in userspace? But yes, at least using appropriate functions should be required. And this means that you can't only check for -ENOSPC, but you need to check for all possible error codes (IS_ERR_VALUE() I guess). Kevin -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
