On 09/12/11 19:38, Pekka Enberg wrote:
> On Fri, Dec 9, 2011 at 8:55 AM, Matt Evans <matt@xxxxxxxxxx> wrote:
>> Add a --hugetlbfs commandline option to give a path to hugetlbfs-map guest
>> memory (down in kvm__arch_init()). For x86, guest memory is a normal
>> ANON mmap() if this option is not provided, otherwise a hugetlbfs mmap.
>>
>> Signed-off-by: Matt Evans <matt@xxxxxxxxxx>
>
>> +void *mmap_hugetlbfs(const char *htlbfs_path, u64 size)
>> +{
>> + char mpath[PATH_MAX];
>> + int fd;
>> + int r;
>> + struct statfs sfs;
>> + void *addr;
>> +
>> + do {
>> + /*
>> + * QEMU seems to work around this returning EINTR... Let's do
>> + * that too.
>> + */
>> + r = statfs(htlbfs_path, &sfs);
>> + } while (r && errno == EINTR);
>
> Can this really happen? What about EAGAIN? The retry logic really
> wants to live in tools/kvm/read-write.c as a xstatfs() wrapper if we
> do need this.
I don't think it can. As per the comment, I thought QEMU knew something I
didn't but I haven't seen any other reason for doing this. I'll remove it,
thanks for the sanity jolt.
Matt
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
