On 2011-12-10 16:49, Blue Swirl wrote:
>>
>> +ISADevice *pit_init(int base, qemu_irq irq)
>
> Please retain this function in pc.h, or even better, introduce i8254.h.
No concerns about i8254.h, but this function does not qualify for static
inline.
>
>> +{
>> + ISADevice *dev;
>> +
>> + dev = isa_create("isa-pit");
>> + qdev_prop_set_uint32(&dev->qdev, "iobase", base);
>> + qdev_init_nofail(&dev->qdev);
>> + qdev_connect_gpio_out(&dev->qdev, 0, irq);
>> +
>> + return dev;
>> +}
>> +
Jan
Attachment:
signature.asc
Description: OpenPGP digital signature
