On 12/06/2011 11:04 AM, Takuya Yoshikawa wrote: > I removed em_grp1a() and em_grp9() but kept em_grp2() and em_grp45() > because they would produce a lot of trivial functions. We could convert the various emulate_2op_blah() macros to generate functions instead of statements, that would greatly reduce the boilerplate. > Though I think it's almost done about the conversions, I do not have > strong opinion about how to treat the remaining instructions: define > em_default() and put those into it may be one way. With em_insn() you have direct visibility as to what a decode table entry describes. That doesn't work with em_default() or em_grpX(). > Anyway, now, rather readable than before. > Yes. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
