Re: [PATCH 1/4] KVM: x86 emulator: Use opcode::execute for Group 2 instructions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/06/2011 11:05 AM, Takuya Yoshikawa wrote:
> Group 2: C0, C1, D0, D1, D2, D3
>
> According to the SDM, the case 6 of em_grp2() should be treated as
> undefined and the opcode D2/D3 should be decoded using the SrcCL.
>
>
>  		emulate_2op_SrcB(ctxt, "rcr");
>  		break;
>  	case 4:	/* sal/shl */
> -	case 6:	/* sal/shl */
>  		emulate_2op_SrcB(ctxt, "sal");
>  		break;
>  	case 5:	/* shr */

AMD processors decode grp2 /6 as sal/shl.  In any case, please don't mix
functional changes with refactoring.


-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux