On 12/07/2011 02:37 PM, Sasha Levin wrote: > > > > It's really implied by the fact that vcpu ioctls must be issued from the > > same thread. > > Oh, I totally forgot about that (here, and in my 'kvm nmi' patch). It keeps biting people. We should make the kernel warn about it. The reason it's important is because we might some day want to move to a syscall based API, rather than ioctl based. In this model a vcpu is bound to the thread that calls kvm_create_vcpu(2), and all vcpu syscalls derive the vcpu from the thread. This model is more natural than the ioctl model, however it is a lot of work and doesn't solve any real life problems; it only creates a larger compatibility burden. But it's still the right thing. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
