On 12/06/2011 05:18 PM, Stefan Hajnoczi wrote:
On Tue, Dec 6, 2011 at 6:33 AM, Jason Wang<jasowang@xxxxxxxxxx> wrote:
On 12/05/2011 06:55 PM, Stefan Hajnoczi wrote:
On Mon, Dec 5, 2011 at 8:59 AM, Jason Wang<jasowang@xxxxxxxxxx> wrote:
+static int virtnet_set_fd(struct net_device *dev, u32 pfn)
+{
+ struct virtnet_info *vi = netdev_priv(dev);
+ struct virtio_device *vdev = vi->vdev;
+
+ if (virtio_has_feature(vdev, VIRTIO_NET_F_HOST_FD)) {
+ vdev->config->set(vdev,
+ offsetof(struct virtio_net_config_fd,
addr),
+&pfn, sizeof(u32));
Please use the virtio model (i.e. virtqueues) instead of shared
memory. Mapping a page breaks the virtio abstraction.
Using control virtqueue is more suitable but there's are also some problems:
One problem is the interface, if we use control virtqueue, we need a
interface between the backend and tap/macvtap to change the flow mapping.
But qemu and vhost_net only know about the file descriptor, more
informations or interfaces need to be exposed in order to let ethtool or
ioctl work.
QEMU could provide map a shared page with tap/macvtap. The difference
would be that the guest<->host interface is still virtio and QEMU
pokes values into the shared page on behalf of the guest.
This makes sense.
Another problem is the delay introduced by ctrl vq, as the ctrl vq would be
used in the critical path in guest and it use busy wait to get the response,
the delay is not neglectable.
Then you need to find a better way of doing this. Can the host
automatically associate the flow from the tx virtqueue packets are
transmitted on? Does it make sense to add a virtio_net_hdr field that
updates the queue mapping?
It can but it can not properly handling the the packet re-ordering
caused by the moving of guest applications among guest cpus. One more
problem for virtio_net_hdr is we need to build a empty packet when there
no other packet to send.
One solution is to introduce unblock cmd for ctrl vq.
The vcpus are just threads and may not be bound to physical CPUs, so
what is the big picture here? Is the guest even in the position to
set the best queue mappings today?
Not sure it could publish the best mapping but the idea is to make sure
the packets of a flow were handled by the same guest vcpu and may be the
same vhost thread in order to eliminate the packet reordering and lock
contention. But this assumption does not take the bouncing of vhost or
vcpu threads which would also affect the result.
Anyway, the mapping from guest was an important reference.
Stefan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
