On 12/01/2011 06:19 PM, Eric B Munson wrote: > On Thu, 01 Dec 2011, Jan Kiszka wrote: > >> On 2011-11-29 22:36, Eric B Munson wrote: >>> + >>> static void cpu_update_state(void *opaque, int running, RunState state) >>> { >>> CPUState *env = opaque; >>> >>> if (running) { >>> env->tsc_valid = false; >>> + kvm_put_guest_paused(env); >> >> checkpatch.pl would have asked you to remove this tab. > > Will change to spaces for V2. > Huh. Remove what tab? Indent are always 8-space TAB according CodingStyle doc: Chapter 1: Indentation Tabs are 8 characters, and thus indentations are also 8 characters. There are heretic movements that try to make indentations 4 (or even 2!) characters deep, and that is akin to trying to define the value of PI to be 3. Gr. AvS -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html