On Wed, Nov 23, 2011, Avi Kivity wrote about "Re: [PATCH] Allow aligned byte and word writes to IOAPIC registers.": > On 11/22/2011 06:09 PM, Julian Stecklina wrote: > > This fixes byte accesses to IOAPIC_REG_SELECT as mandated by at least the > > ICH10 and Intel Series 5 chipset specs. It also makes ioapic_mmio_write > > consistent with ioapic_mmio_read, which also allows byte and word accesses. > > > > Your patch indents with spaces, while Linux uses tabs for indents. You might want to run scripts/checkpatch.pl on your patches before sending them - this will catch this and many other stylistic faux pas. -- Nadav Har'El | Wednesday, Nov 23 2011, nyh@xxxxxxxxxxxxxxxxxxx |----------------------------------------- Phone +972-523-790466, ICQ 13349191 |Why do doctors call what they do http://nadav.harel.org.il |practice? Think about it. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html