On 11/10/2011 04:20 PM, Alexander Graf wrote: >> looks like this is different in the 32x86 ABI. >> >> We can pad explicitly if you prefer. > The size is 16 on 32-bit ppc -- the alignment of __u64 forces this. It > > I would prefer if we keep this stable :). There's no good reason to > pad it - ppc64 creates the same struct definition. There are over 500 > entries currently, and QEMU could make it much larger >> if it wants to decrease guest-visible faults on certain workloads. >> >> It's not the most important feature, indeed we currently ignore the >> bitmap entirely. But it could be useful depending on how the API is >> used in the future, and I don't think we gain much by dropping it at >> this point. Alex, any thoughts? > > The kernel can always opt in to ignore the field if it chooses to, so > I don't see the point in dropping it. There shouldn't be an alignment > problem in the first place :). Ok. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html