On Thu, Nov 03, 2011 at 02:31:18PM +0200, Michael S. Tsirkin wrote: > On Wed, Nov 02, 2011 at 08:30:28PM -0400, Kevin O'Connor wrote: > > On Wed, Nov 02, 2011 at 10:54:42AM +0200, Michael S. Tsirkin wrote: > > > On Tue, Nov 01, 2011 at 06:59:01PM -0400, Kevin O'Connor wrote: > > > > Can we leave these parts in the DSDT and only move the bulk generated > > > > stuff to the SSDT? > > > > > > > They can, but I thought one of the reasons we do the split > > > is to make it possible for users to supply their own DSDT? > > > If so creating calls from SSDT into DSDT would make this very fragile. > > > > I think it's reasonable to require that a user supplied DSDT still > > fill certain requirements. Keep in mind that the reason for the "user > > supplied" DSDT was for new platform (q35) development - not > > necessarily so each individual user could set their own. > > > > It's not great to have the DSDT and SSDT tied to each other. However, > > once RMV is removed, it's only two methods (PCNT supplied by the SSDT > > and PCEJ supplied by the DSDT). > > > > I do see the upside to moving it all to the SSDT - but that has the > > disadvantage of taking away the ability of a user supplied DSDT to > > tweak how the hotplug functions work. > > Is this something q35 needs? q35 emulator will discard qemu-specific pci hotplug(hw/acpi_piix4.c). Instead, pcie hotplug is introduced. (that's my plan at least.) So pci hotplug code in acpi (DSDT or SSDT) for acpi_piix4 needs to be suppressed somehow. thanks, > > Also, we'd then want to redo CPU hotplug to be the same way. > > OK, I'll do that if we decide this is a good direcction. > > > -Kevin > > _______________________________________________ > SeaBIOS mailing list > SeaBIOS@xxxxxxxxxxx > http://www.seabios.org/mailman/listinfo/seabios > -- yamahata -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
