On 10/31/11 9:38 AM, "Rose, Gregory V" <gregory.v.rose@xxxxxxxxx> wrote: >> -----Original Message----- >> From: netdev-owner@xxxxxxxxxxxxxxx [mailto:netdev-owner@xxxxxxxxxxxxxxx] >> On Behalf Of Roopa Prabhu >> Sent: Friday, October 28, 2011 7:34 PM >> To: netdev@xxxxxxxxxxxxxxx >> Cc: sri@xxxxxxxxxx; dragos.tatulea@xxxxxxxxx; kvm@xxxxxxxxxxxxxxx; >> arnd@xxxxxxxx; mst@xxxxxxxxxx; davem@xxxxxxxxxxxxx; Rose, Gregory V; >> mchan@xxxxxxxxxxxx; dwang2@xxxxxxxxx; shemminger@xxxxxxxxxx; >> eric.dumazet@xxxxxxxxx; kaber@xxxxxxxxx; benve@xxxxxxxxx >> Subject: [net-next-2.6 PATCH 0/6 RFC v3] macvlan: MAC Address filtering >> support for passthru mode >> >> v2 -> v3 >> - Moved set and get filter ops from rtnl_link_ops to netdev_ops >> - Support for SRIOV VFs. >> [Note: The get filters msg might get too big for SRIOV vfs. >> But this patch follows existing sriov vf get code and >> accomodate filters for all VF's in a PF. >> And for the SRIOV case I have only tested the fact that the VF >> arguments are getting delivered to rtnetlink correctly. The rest of >> the code follows existing sriov vf handling code so it should work >> just fine] >> - Fixed all op and netlink attribute names to start with IFLA_RX_FILTER >> - Changed macvlan filter ops to call corresponding lowerdev op if lowerdev >> supports it for passthru mode. Else it falls back on macvlan handling >> the >> filters locally as in v1 and v2 >> >> v1 -> v2 >> - Instead of TUNSETTXFILTER introduced rtnetlink interface for the same >> > > [snip...] > >> >> This patch series implements the following >> 01/6 rtnetlink: Netlink interface for setting MAC and VLAN filters >> 02/6 netdev: Add netdev_ops to set and get MAC/VLAN rx filters >> 03/6 rtnetlink: Add support to set MAC/VLAN filters >> 04/6 rtnetlink: Add support to get MAC/VLAN filters >> 05/6 macvlan: Add support to set MAC/VLAN filter netdev ops >> 06/6 macvlan: Add support to get MAC/VLAN filter netdev ops >> >> Please comment. Thanks. > > After some preliminary review this looks pretty good to me in so far as adding > the necessary hooks to do what I need to do. I appreciate your effort on > this. > > I'm sort of a hands-on type of person so I need to apply this patch to a > private git tree and then take it for a test drive (so to speak). If I have > further comments I'll get back to you. > Sounds good. > Did you have any plans for modifying any user space tools such as 'ip' to use > this interface? > Yes, I have an iproute2 sample patch for setting and displaying the filters which I have been using to test this interface. I can send the patch to you after some cleanup if you think it will be useful for you to try out this interface. Thanks Greg. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
