Re: qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/26/2011 01:47 PM, Kevin Wolf wrote:
Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
Hi folks:

We've captured a regression with floppy disk on recent qemu (and
qemu-kvm, after a code merge). We bisected it to be caused by:

commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
Author: Richard Henderson<rth@xxxxxxxxxxx>
Date:   Mon Aug 15 15:08:45 2011 -0700

      fdc: Convert to isa_register_portio_list

      Signed-off-by: Richard Henderson<rth@xxxxxxxxxxx>
      Signed-off-by: Avi Kivity<avi@xxxxxxxxxx>

Since this commit, the guest doesn't see a floppy disk attached to it
anymore, blocking kvm autotest ability to install windows guests
automatically. This is a big deal for kvm autotest (ruins our automated
regression jobs), so please take a look at it.

Can you please try again with the latest block branch? I think there is
a patch queued that will fix it.

Kevin, I did try with HEAD of your repo:

git://repo.or.cz/qemu/kevin.git

[lmr@freedom qemu-kwolf]$ git branch -r
  origin/HEAD -> origin/master
  origin/blkqueue
  origin/blkqueue-v1
  origin/block
  origin/coroutine
  origin/coroutine-block
  origin/coroutine-devel
  origin/devel
  origin/ehci
  origin/for-anthony
  origin/for-stable-0.14
  origin/inplace-conversion
  origin/master

With this repo, master branch, the problem persists. With the block branch, the problem persists.

Now, with the blkqueue branch the problem is resolved. Cleber had the same results booting a FreeDOS floppy. So the fix is indeed in blkqueue.

Oh, you might want to check the blkqueue branch, it does have quite a bunch of set but unused variables, which will cause compilation errors unless --disable-werror is passed to the configure script.

Please merge the fixes with qemu master as soon as you can, we are probably leave windows installs from the upstream daily jobs until the fixes get to master.

Thanks,

Lucas
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux