On Mon, Oct 24, 2011 at 12:34:04AM +0530, Raghavendra K T wrote: > Add debugfs support to print u32-arrays in debugfs. Move the code from Xen to debugfs > to make the code common for other users as well. You forgot the kerneldoc for the function explaining what it is and how to use it, and the EXPORT_SYMBOL_GPL() marking for the global function as that's the only way it will be able to be used, right? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html