On Mon, Oct 17, 2011 at 09:00:12PM +0200, Jan Kiszka wrote:
> On 2011-10-17 14:16, Michael S. Tsirkin wrote:
> > On Mon, Oct 17, 2011 at 11:27:56AM +0200, Jan Kiszka wrote:
> >> Also invoke the mask notifier if the global MSI-X mask is modified. For
> >> this purpose, we push the notifier call from the per-vector mask update
> >> to the central msix_handle_mask_update.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
> >
> > This is a bugfix, isn't it?
> > If yes it should be separated and put on -stable.
>
> Yep, will pull this to the front.
I'll apply this to qemu.git, no need to mix bugfixes
with features ...
> >
> >> ---
> >> hw/msix.c | 16 +++++++++-------
> >> 1 files changed, 9 insertions(+), 7 deletions(-)
> >>
> >> diff --git a/hw/msix.c b/hw/msix.c
> >> index 739b56f..247b255 100644
> >> --- a/hw/msix.c
> >> +++ b/hw/msix.c
> >> @@ -221,7 +221,15 @@ static bool msix_is_masked(PCIDevice *dev, int vector)
> >>
> >> static void msix_handle_mask_update(PCIDevice *dev, int vector)
> >> {
> >> - if (!msix_is_masked(dev, vector) && msix_is_pending(dev, vector)) {
> >> + bool masked = msix_is_masked(dev, vector);
> >> + int ret;
> >> +
> >> + if (dev->msix_mask_notifier) {
> >> + ret = dev->msix_mask_notifier(dev, vector,
> >> + msix_is_masked(dev, vector));
> >
> > Use 'masked' value here as well?
>
> Yes.
>
> Jan
>
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
