On 10/17/2011 01:25 PM, Jan Kiszka wrote: > On 2011-10-17 13:13, Avi Kivity wrote: > > On 10/17/2011 11:27 AM, Jan Kiszka wrote: > >> Keep a link from the internal KVM routing table to potential MSI routing > >> cache entries. The link is used so far whenever the entry is dropped to > >> invalidate the cache content. It will allow us to build MSI routing > >> entries on demand and flush existing ones on table overflow. > >> > > > > Does this not require a destructor for MSIRoutingCache? > > Yes, kvm_msi_cache_invalidate. Cache providers are responsible for > invalidating used caches before freeing them. That also drops the > reference established here. Ah, apic.c's cache is static. It looked to me as if you're immediately leaking references to it, but you aren't. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html