On 10/02/2011 06:33 PM, Jan Kiszka wrote:
On 2011-10-02 18:30, Avi Kivity wrote:
> On 10/02/2011 06:28 PM, Jan Kiszka wrote:
>> > @@ -615,9 +617,12 @@ static void update_cpuid(struct kvm_vcpu *vcpu)
>> > if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL&&
>> > best->function == 0x1) {
>> > best->ecx |= bit(X86_FEATURE_TSC_DEADLINE_TIMER);
>> > - vcpu->arch.apic->lapic_timer.timer_mode_mask = (3<< 17);
>> > + timer_mode_mask = 3<< 17;
>> > } else
>> > - vcpu->arch.apic->lapic_timer.timer_mode_mask = (1<< 17);
>> > + timer_mode_mask = 1<< 17;
>> > +
>> > + if (apic)
>> > + apic->lapic_timer.timer_mode_mask = timer_mode_mask;
>>
>> Coding style... While at it, you could also fix braces for that else.
>>
>
> Too late... committed and pushed, and Marcelo holds the baton now.
Err, sorry, this was false alarm anyway: Its perfectly valid kernel
style - for the kernel, not qemu. :)
Actually CodingStyle does recomment consistent bracing in the if {
multiline } else singleline case.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
