Currently we use initrd and kernel params to perform unattended install in all supported linux guests. Before that, we used to remove those params from the qemu params because they alledgedly 'broke' the migration. Well, turns out this code renders our migrate in background code path useless, and it does not appear to break migration on the tests I've made. So, let's just get rid of it and be happy. Signed-off-by: Lucas Meneghel Rodrigues <lmr@xxxxxxxxxx> --- client/tests/kvm/tests/unattended_install.py | 10 ---------- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/client/tests/kvm/tests/unattended_install.py b/client/tests/kvm/tests/unattended_install.py index 023d00f..b1d23f6 100644 --- a/client/tests/kvm/tests/unattended_install.py +++ b/client/tests/kvm/tests/unattended_install.py @@ -611,16 +611,6 @@ def run_unattended_install(test, params, env): pass if migrate_background: - # Drop the params which may break the migration - # Better method is to use dnsmasq to do the - # unattended installation - if vm.params.get("initrd"): - vm.params["initrd"] = None - if vm.params.get("kernel"): - vm.params["kernel"] = None - if vm.params.get("extra_params"): - vm.params["extra_params"] = re.sub("--append '.*'", "", - vm.params["extra_params"]) vm.migrate(timeout=mig_timeout, protocol=mig_protocol) else: time.sleep(1) -- 1.7.6 -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html