On 2011-09-21 10:06, Stefan Hajnoczi wrote: > On Tue, Sep 20, 2011 at 06:49:49PM +0200, Jan Kiszka wrote: >> Upstream's version is about to be signal-free and will stop handling >> SIGUSR2 specially. So it's time to adopt its implementation, ie. switch >> from signalfd to a pipe. >> >> Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx> >> --- >> >> This should help pulling upstream into qemu-kvm when "block: avoid >> SIGUSR2" is merged. And will help merging further cleanups of this code >> I'm working on. >> >> posix-aio-compat.c | 73 ++++++++++++++++++++++----------------------------- >> 1 files changed, 32 insertions(+), 41 deletions(-) > > Reviewed-by: Stefan Hajnoczi <stefanha@xxxxxxxxxxxxxxxxxx> > > Perhaps qemu_eventfd() can be used in the future instead of an explicit > pipe. Then Linux will do eventfd while other OSes will fall back to > pipes. Basically simpler code, or does this also have runtime benefits? Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html