Re: [PATCH v2] kvm tools: Support multiple net devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2011-09-26 at 20:11 +0800, Asias He wrote:
> On 09/26/2011 07:59 PM, Sasha Levin wrote:
> > On Mon, 2011-09-26 at 19:57 +0800, Asias He wrote:
> >> On 09/25/2011 07:11 PM, Sasha Levin wrote:
> >>> This patch adds support for multiple network devices. The command
> >> line syntax
> >>> changes to the following:
> >>>
> >>>       --network/-n [mode=[tap/user/none]] [guest_ip=[guest ip]]
> >> [host_ip=
> >>> [host_ip]] [guest_mac=[guest_mac]] [script=[script]]
> >>
> >> This syntax is actually, no?
> >>
> >>    --network/-n mode=tap,guest_ip=x.x.x.x
> >>
> >> not
> >>
> >>    --network/-n mode=tag guest_ip=x.x.x.x
> >>
> >>
> >> This works for me:
> >> $ sudo ./kvm run -d sid.img -p root=/dev/vda1 -k bzImage  \
> >> -n mode=tap,host_ip=192.168.100.1 -n mode=tap,host_ip=192.168.200.1
> >>
> >> This does not work for me:
> >> $ sudo ./kvm run -d sid.img -p root=/dev/vda1 -k bzImage \
> >> -n mode=tap host_ip=192.168.100.1 -n mode=tap host_ip=192.168.200.1
> > 
> > Yes, with ',' ofcourse :)
> 
> Sasha, Can you drop these []?  There are way too many []. Although []
> tells user this option is optional.
> 
> --network/-n [mode=[tap/user/none]] [guest_ip=[guest ip]] [host_ip=
> [host_ip]] [guest_mac=[guest_mac]] [script=[script]]
> 
> 
> Does this look ok?
> --network/-n
> mode=tap|user|none,guest_ip=x.x.x.x,host_ip=x.x.x.x,guest_mac=xx:xx:xx:xx:xx:xx,script=script.sh

We really need them to specify they are optional.

How about this:

--network/-n
[mode=tap/user/none][,guest_ip=ip][,host_ip=ip][,guest_mac=mac][,script=file]

-- 

Sasha.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux