Re: [Autotest] [PATCH] KVM-test: Add two scripts to disable services for perf tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



----- Original Message -----
> On Wed, Sep 7, 2011 at 3:07 AM, Amos Kong <akong@xxxxxxxxxx> wrote:
> > System services on guest and host take uncertain resource, it
> > effects
> > the perf results. We can use the below two scripts to disable some
> > services of host and guest.
> >
> > stop_serivices_perf.sh is used to stop the running serivices.
> > off_service_perf.sh is used to off services when host starts up.
> 
> Hi Amos, thanks! I've been thinking about those scripts, let me
> summarize my thoughts:
> 
>  * If we are going to make this using scripts, then we should try as
> much as possible to be distro agnostic.

>  * We could detect services present on guest first before trying to
> disable them, ie, instead of just issuing a service koan stop, verify
> if there's a /etc/init.d/koan first.

We have a black list, if one server exist in the guest (/etc/init.d/*),
then stop it.

Some services need to be disabled by 'chkconfig * off', we can execute a python/shell
script in post installation, checking if service exists is also necessary.

>  * Have you considered doing this env setup using shell commands
>  typed
> on an ssh session, such as
> 
>  session = vm.wait_for_login()
>  session.cmd('service auditd stop')
> 
> Rather than a script? It's one less script to maintain under the
> scripts/ directory.
> 
>  * Your approach is a blacklist of services that will be turned off.
> What if we used a 'whitelist' approach and kept a list of the
> fundamental services needed and turn off *everything else*?

Blacklist is safe and better, the whitelist is difficult to maintain.

> Please let me know what you think about this. I'm not applying this
> for now.
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux