----- Original Message ----- > ----- Original Message ----- > > On Thu, 15 Sep 2011 21:00:38 +0800, Amos Kong <akong@xxxxxxxxxx> > > wrote: > > > > > + netdev->xid = random(); > > > > This will not work for reboots. The decision that the hardware > > address > > is > > choosen was not accidental. Not sure if some DHCP server will count > > on > > the > > ID. (RFC 2131 "Retain DHCP client configuration across server > > reboots, > > and, > > whenever possible, a DHCP client should be assigned the same > > configuration > > parameters despite restarts of the DHCP mechanism"). If not so I am > > fine > > with the patch. Hi Hagen, rfc2131 clearly describes that we need a random xid, I don't think xid is a port of "DHCP client configuration", it only be used to associate messages and responses between client and server. I would post a patch to ipxe maillist later if it's ok. Thanks, Amos > But a DHCP client should be identified by its MAC, not the xid. > Y. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
