On 09/14/2011 06:21 PM, Takuya Yoshikawa wrote:
> > Nothing should be accessed from outside the emulator, except via > accessors. We should move initialization to the emulator as well (or > just initialize from x86_decode_insn() - any reason not to?) Not big reason but kvm_inject_realmode_interrupt() and kvm_task_switch() call emulate_int_real() and emulator_task_switch() respectively without doing generic decoding. So at least, we need some special initialization for them if we move init_emulate_ctxt() into x86_decode_insn().
Best if x86_decode_insn(), emulate_int_real(), and emulator_task_switch() all call an internal initialization function. This way the external caller doesn't have to worry about the details.
-- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html