On Tue, Sep 13, 2011 at 10:58:55AM -0400, Greg KH wrote: > On Tue, Sep 13, 2011 at 04:54:02PM +0200, Roedel, Joerg wrote: > > --- a/include/linux/device.h > > +++ b/include/linux/device.h > > @@ -22,6 +22,7 @@ > > #include <linux/types.h> > > #include <linux/module.h> > > #include <linux/pm.h> > > +#include <linux/iommu.h> > > Ick, please don't add new #includes to device.h, it makes the whole > build slower. Just pre-declare the structure and all should be fine. Okay, will do. Thanks. > Don't you need to also redo the other patches in this series based on > the other comments you received? Unless I have missed something I am not aware of other comments that need action by now. Sethi pointed out that the KVM device assignment code needs rework to be usable outside of PCI too. But that work is already underway with Alex Williamson's VFIO framework and not scope of this patch-set. Regards, Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632 -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html