On Fri, 2011-09-02 at 21:13 +0300, Gleb Natapov wrote: > On Fri, Sep 02, 2011 at 08:55:55PM +0300, Sasha Levin wrote: > > Hi, > > > > I've noticed that kvm_irq_delivery_to_apic() is locating the destination > > APIC by running through kvm_for_each_vcpu() which becomes a scalability > > issue with a large number if vcpus. > > > > I'm thinking about speeding that up using a radix tree for lookups, and > > was wondering if it sounds right. > > > We have to call kvm_apic_match_dest() on each apic to see if it should > get the message. Single message can be sent to more than one apic. It is > likely possible to optimize common case of physical addressing fixed > destination, but then just use array of 256 elements, no need for a tree. I think it's also possible to handle it for logical addressing as well, instead of a simple compare we just need to go through all the IDs that would 'and' with the dest. > Do you see this function in profiling? I was running profiling to see which functions get much slower during regular operation (not boot) when you run with large amount of vcpus, and this was one of them. Though this is probably due to the method we use to find lowest priority and not the lookups themselves. -- Sasha. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
