On Thu, 2011-09-01 at 23:19 +0300, Gleb Natapov wrote: > On Thu, Sep 01, 2011 at 11:05:00PM +0300, Sasha Levin wrote: > > On Thu, 2011-09-01 at 23:03 +0300, Gleb Natapov wrote: > > > On Thu, Sep 01, 2011 at 10:58:31PM +0300, Sasha Levin wrote: > > > > By "actual addressing model" I meant checking the ICR of of each APIC to > > > > see if we should address it logically or physically. > > > > > > > This is definitely not what ICR of each APIC is about. > > > > Thats what I understood from section 10.6.2 in the spec. > > > Section 10.6.2 talks about ACPI messages generated by a CPU (IPIs) not > about addressing mode of the CPU itself (which is, again, per message). Right, but it was referred to by section 10.11.1, that's why I assumed so. Anyway, I'll just replace the patch with what you've initially suggested, so it would be contained within kvm_set_msi(). -- Sasha. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html