Re: [RFC PATCH v3 3/4] lock to protect memslots

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/15/2011 11:15 PM, Paolo Bonzini wrote:
On 08/15/2011 01:27 PM, Umesh Deshpande wrote:
Yes, the mru list patch would obviate the need of holding the ram_list
mutex in qemu_get_ram_ptr.

Feel free to take it and complete it with locking then!

Also, I was planning to protect the whole migration thread with iothread
mutex, and ram_list mutex. (i.e. holding ram_list mutex while sleeping
between two iterations, when we release iothread mutex). This will
prevent the memslot block removal altogether during the migration. Do
you see any problem with this?

No, indeed holding the ram_list mutex through all the migration "fixes"
the problems with ram_lists removing during migration. I guess whoever
will implement memory hotplug, will find a way around it. :)

BTW, now that I think of it, do you have ideas on how to do the migration thread do block migration?

Paolo

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux