Re: [Qemu-devel] [PATCH 2/3] memory: add API for creating ROM/device regions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/12/2011 06:48 AM, Anthony Liguori wrote:
      target_phys_addr_t offset_in_region;
      AddrRange addr;
      uint8_t dirty_log_mask;
+    bool readable;
@@ -125,6 +125,7 @@ struct FlatRange {

In a follow up, it might be good to add a comment explaining that this whole readable thing is not just an optimization, but a hard requirement for KVM in order to be able to execute code from ROM.

This has nothing to do with kvm (in fact, I think we cannot support it under kvm with current interfaces). It's there to support devices that sometimes act as RAM and sometimes as mmio.

We could also do it with a container and playing with subregions. I tried it and it was pretty complicated.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux