Re: [Qemu-devel] [PATCH 18/24] versatile_pci: convert to memory API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/11/2011 07:20 PM, Peter Maydell wrote:
On 8 August 2011 18:07, Avi Kivity<avi@xxxxxxxxxx>  wrote:
>  -static uint32_t pci_vpb_config_readb (void *opaque, target_phys_addr_t addr)
>  +static uint64_t pci_vpb_config_read(void *opaque, target_phys_addr_t addr,
>  +                                    unsigned size)
>    {
>       uint32_t val;
>  -    val = pci_data_read(opaque, vpb_pci_config_addr (addr), 1);
>  -    return val;
>  +    val = pci_data_read(opaque, vpb_pci_config_addr(addr), size);
>  +    return size;
>    }

This should be 'return val', not 'return size', I think...

Wow, how did that happen?

(otherwise PCI is broken on versatilepb; tested with your memory-region
branch rather than with this particular patch.)


Updated patch to follow, thanks for the report.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux