On Fri, Jul 29, 2011 at 05:01:16AM -0400, Zachary Amsden wrote: > So you are right, this is still wrong for the case in which L1 does > not trap TSC MSR reads. Note however, the RDTSC instruction is still > virtualized properly, it is only the relatively rare actual TSC MSR > read via RDMSR which is mis-virtualized (this bug exists today in the > SVM implementation if I am reading it correctly - cc'd Joerg to notify > him of that). That, combined with the relative importance of > supporting a guest which does not trap on these MSR reads suggest this > is a low priority design issue however (RDTSC still works even if the > MSR is trapped, correct?) Actually, the documentation is not entirely clear about this. But I tend to agree that direct _reads_ of MSR 0x10 in guest-mode should return the tsc with tsc_offset applied. But on the other side, there is even SVM hardware which does this wrong. For some K8s there is an erratum that the tsc_offset is not applied when the MSR is read directly in guest mode. But yes, to be architecturaly correct the msr read should always return the tsc of the currently running guest level. In reality this shouldn't be am issue, though, and rdtsc[p] is still working correctly. Regards, Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632 -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
