On Mon, 25 Jul 2011, Avi Kivity wrote: > On 07/25/2011 06:16 PM, malc wrote: > > On Mon, 25 Jul 2011, Avi Kivity wrote: > > > > > As with the rest of the memory API, the caller associates an eventfd > > > with an address, and the memory API takes care of registering or > > > unregistering when the address is made visible or invisible to the > > > guest. > > > > > > Signed-off-by: Avi Kivity<avi@xxxxxxxxxx> > > [..snip..] > > > > > +static bool memory_region_ioeventfd_before(MemoryRegionIoeventfd a, > > > + MemoryRegionIoeventfd b) > > > +{ > > > + if (a.addr.start< b.addr.start) { > > > + return true; > > > + } else if (a.addr.start> b.addr.start) { > > > + return false; > > > + } else if (a.addr.size< b.addr.size) { > > > + return true; > > > + } else if (a.addr.size> b.addr.size) { > > > + return false; > > > + } else if (a.match_data< b.match_data) { > > > + return true; > > > + } else if (a.match_data> b.match_data) { > > > + return false; > > > + } else if (a.match_data) { > > > + if (a.data< b.data) { > > > + return true; > > > + } else if (a.data> b.data) { > > > + return false; > > > + } > > > + } > > > + if (a.fd< b.fd) { > > > + return true; > > > + } else { if (a.fd> b.fd) { > > > + return false; > > > + } } > > > > Braces.. > > > > Where? add? remove? > You authored the coding_style document btw. -- mailto:av1474@xxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html