On Mon, Jul 25, 2011 at 5:51 PM, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: > On 07/25/2011 04:23 PM, Blue Swirl wrote: >> >> > Yes. We can just make qemu_malloc use g_malloc. >> >> It would be also possible to make g_malloc() use qemu_malloc(). That >> way we could keep the tracepoints which would lose their value with >> g_malloc() otherwise. > > qemu_malloc uses g_malloc => you keep tracepoints, you just do not trace > memory allocated by glib Unless the plan is to replace all qemu_malloc() calls with calls to g_malloc(). > g_malloc uses qemu_malloc => you keep and expand tracepoints, you lose the > very nicely tuned allocator It is replaced by libc malloc() which shouldn't be so bad either. > The former is much less code, however it requires qemu_malloc to be always > balanced with qemu_free (patches ready and on my github tree, won't be sent > before KVM Forum though...). Freeing qemu_malloc() memory with plain free() is a bug. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
