On 07/21/2011 10:55 PM, Blue Swirl wrote:
On Wed, Jul 20, 2011 at 7:49 PM, Avi Kivity<avi@xxxxxxxxxx> wrote:
> As with the rest of the memory API, the caller associates an eventfd
> with an address, and the memory API takes care of registering or
> unregistering when the address is made visible or invisible to the
> guest.
>
> +
> +static bool memory_region_ioeventfd_before(MemoryRegionIoeventfd a,
> + MemoryRegionIoeventfd b)
> +{
> + if (a.addr.start< b.addr.start) return true;
> + if (a.addr.start> b.addr.start) return false;
> + if (a.addr.size< b.addr.size) return true;
> + if (a.addr.size> b.addr.size) return false;
> + if (a.match_data< b.match_data) return true;
> + if (a.match_data> b.match_data) return false;
> + if (a.match_data) {
> + if (a.data< b.data) return true;
> + if (a.data> b.data) return false;
> + }
> + if (a.fd< b.fd) return true;
> + if (a.fd> b.fd) return false;
NACK for CO.. Wait, is this another trap?
This is already fixed in my tree; v5 was already posted when you made
your review (or at least, when I read it).
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
