Re: [Qemu-devel] [RFC v4 11/58] memory: add ioeventfd support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/20/2011 08:29 PM, Blue Swirl wrote:
>  +
>  +static bool memory_region_ioeventfd_before(MemoryRegionIoeventfd a,
>  +                                           MemoryRegionIoeventfd b)
>  +{
>  +    if (a.addr.start<  b.addr.start) return true;
>  +    if (a.addr.start>  b.addr.start) return false;
>  +    if (a.addr.size<  b.addr.size) return true;
>  +    if (a.addr.size>  b.addr.size) return false;
>  +    if (a.match_data<  b.match_data) return true;
>  +    if (a.match_data>  b.match_data) return false;
>  +    if (a.match_data) {
>  +        if (a.data<  b.data) return true;
>  +        if (a.data>  b.data) return false;
>  +    }
>  +    if (a.fd<  b.fd) return true;
>  +    if (a.fd>  b.fd) return false;

NACK for CODING_STYLE.

Just checking if you're awake.

Will fix.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux