On 01.07.2011, at 10:07, Hannes Reinecke wrote: > On 07/01/2011 10:02 AM, Alexander Graf wrote: >> >> On 01.07.2011, at 09:42, Hannes Reinecke wrote: >> >>> Occasionally, the buffer needs to be placed at a offset within >>> the iovec when copying the buffer to the iovec. >> >> So this is a buffer into the iovec, right? Wouldn't it make sense > > to also modify iov_to_buf respectively then, so the API stays similar? > > Ahem. That's exactly what the patch does. Except from the mixed-up subject. > > iov_to_buff() has an offset parameter, iov_from_buf() has not. > For no obvious reasons. Ah, I see. Please state this in your patch description :). Makes it a lot easier to understand the rationale that you're merely moving the "from" API towards the same parameters as to "to" one. > >> Also, it'd be nice to give the parameter a more obvious name, so potential > > users can easily recognize what it offsets. >> > Yes, that sounds reasonable. > > What about 'iov_off' ? > (And possibly rename 'iovcnt' to 'iov_cnt' for consistency ?) Yup, that'd be a lot more readable :) Alex -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
