* Izik Eidus (izik.eidus@xxxxxxxxxxxxxxxxxx) wrote: > On 6/22/2011 3:21 AM, Chris Wright wrote: > >* Nai Xia (nai.xia@xxxxxxxxx) wrote: > >>+ if (!shadow_dirty_mask) { > >>+ WARN(1, "KVM: do NOT try to test dirty bit in EPT\n"); > >>+ goto out; > >>+ } > >This should never fire with the dirty_update() notifier test, right? > >And that means that this whole optimization is for the shadow mmu case, > >arguably the legacy case. > > Hi Chris, > AMD npt does track the dirty bit in the nested page tables, > so the shadow_dirty_mask should not be 0 in that case... Yeah, momentary lapse... ;) -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html