Re: KVM: VMX: do not overwrite uptodate vcpu->arch.cr3 on KVM_SET_SREGS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/09/2011 08:11 PM, Marcelo Tosatti wrote:
>
>  Applied and queued, but I think there is something rotten here.  How
>  does arch.cr3 get into GUEST_CR3 after KVM_SET_SREGS?  arch.cr3 is a
>  supposed to be write-through cache - it only has a bit in
>  regs_avail, not regs_dirty.


KVM_SET_SREGS sets good kvm->arch.cr3. Then vmx_decache_cr3 overwrites
kvm->arch.cr3 from GUEST_CR3, which is stale.


Right. Should have called kvm_set_cr3(). It's tricky since we need to set the order of writing various registers, I'll take a look.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux