On 8 June 2011 15:10, Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote: > --- /dev/null > +++ b/scripts/update-linux-headers.sh > @@ -0,0 +1,55 @@ > +#!/bin/sh -e > +# > +if [ -z "$output" ]; then > + Â Âoutput=$PWD > +fi > + Â Âmkdir -p $output/linux-headers/asm-$arch This script is rather lacking in quoting throughout. As a random example, this looks like it will break if you run the script from a directory with a space in the path. > +tmpdir=$TMPDIR/.tmp-hdrs-$$ Better (safer) to use mktemp, I think. > if [ -z "$linux" -o ! -d "$linux" ]; then test -o is obsolescent in POSIX; use if [ -z "$linux" ] || ! [ -d "$linux" ] ; then instead. -- PMM -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
