Re: [PATCH v2] virtio-spec: Fix wrong bit number of device status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 7 Jun 2011 21:09:42 +0800, Amos Kong <akong@xxxxxxxxxx> wrote:
> 
> qemu-kvm/hw/virtio_config.h:
>  #define VIRTIO_CONFIG_S_ACKNOWLEDGE     1
>  #define VIRTIO_CONFIG_S_DRIVER          2
>  #define VIRTIO_CONFIG_S_DRIVER_OK       4
>  #define VIRTIO_CONFIG_S_FAILED          0x80
> 
> virtio-spec:
> ACKNOWLEDGE(1) :
> DRIVER(2)      :
> DRIVER_OK(3)   :
> FAILED(128)    :
> 
> The spec refers to bit numbers and the headers use absolute numbers,
> they are not consistent.
> 
> it shoule be 'FAILED(8)'.
> 2^(8-1) = 128
> 
> Changes from V1:
> - Fix wrong patch body
> 
> Signed-off-by: Amos Kong <akong@xxxxxxxxxx>

Thanks, applied!
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux