On Tuesday 07 June 2011 22:25:15 Alexander Graf wrote: > +static long kvm_vcpu_compat_ioctl(struct file *filp, > + unsigned int ioctl, unsigned long arg) > +{ > + struct kvm_vcpu *vcpu = filp->private_data; > + void __user *argp = (void __user *)arg; Converting a compat user argument into a pointer should use the compat_ptr() function to do the right thing on s390. Otherwise your patch looks good. Arnd -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html