On Mon, 6 Jun 2011 10:11:53 +0200, richard -rw- weinberger <richard.weinberger@xxxxxxxxx> wrote: > On Mon, Jun 6, 2011 at 8:35 AM, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote: > > On Sat, 4 Jun 2011 17:37:04 +0200, Christian Dietrich <christian.dietrich@xxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > >> Since printk_ratelimit() shouldn't be used anymore (see comment in > >> include/linux/printk.h), replace it with printk_ratelimited. > > > > Acked-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx> (lguest part) > > > >> diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c > >> index db832fd..23a6eff 100644 > >> --- a/arch/x86/lguest/boot.c > >> +++ b/arch/x86/lguest/boot.c > >> @@ -56,6 +56,7 @@ > >> Â#include <linux/lguest_launcher.h> > >> Â#include <linux/virtio_console.h> > >> Â#include <linux/pm.h> > >> +#include <linux/ratelimit.h> > >> Â#include <asm/apic.h> > >> Â#include <asm/lguest.h> > >> Â#include <asm/paravirt.h> > > > > Is this new include really needed? ÂThe printk_ratelimited() definition > > is in printk.h... > > Yes. > printk_ratelimited() needs DEFINE_RATELIMIT_STATE() which is defined > in ratelimit.h. Yech. I'm assuming that making printk.h include ratelimit.h makes a nasty mess? Thanks, Rusty. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
