On Mon, Jun 6, 2011 at 11:37 AM, Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:
> On Mon, Jun 06, 2011 at 11:28:56AM +0300, Avi Kivity wrote:
>> On 06/03/2011 10:37 PM, Pekka Enberg wrote:
>> >This patch fixes access to 'ah' in int10_vesa() by masking the high bits.
>> >
>> >@@ -131,7 +131,7 @@ static void int10_vesa(struct int10_args *args)
>> > {
>> > u8 al;
>> >
>> >- al = args->eax;
>> >+ al = args->eax& 0xff;
>>
>> Isn't this reading %al? And the high bits are masked by the type of
>> the variable?
>>
>
> Type conversion will do the work but having explicit masking is
> a way better I believe, at least it makes this code snippet notable.
True but the patch description is bogus as it really doesn't _fix_ anything.
Pekka
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
