Re: [PATCH 3/3] kvm tools, ui: Add support for SDL framebuffer output target

[Ingo Molnar <mingo@xxxxxxx>]

i tried this patch:

diff --git a/tools/kvm/ui/sdl.c b/tools/kvm/ui/sdl.c
index 8bc3f68..403563c 100644
--- a/tools/kvm/ui/sdl.c
+++ b/tools/kvm/ui/sdl.c
@@ -19,6 +19,8 @@ static void *sdl__thread(void *p)
 	SDL_Surface *screen;
 	SDL_Event ev;
 
+	BUG_ON(1);
+
 	if (SDL_Init(SDL_INIT_VIDEO) != 0)
 		die("Unable to initialize SDL");

but it does not trigger.

Oh ... because the SDL library is not present on that box and it 
silently did not get built.

Now *that* is not an obvious failure pattern ;-)

Thanks,
 
	Ingo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html